fix(lsp): verify that nodejs runs (again) #7076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The logic added in a264377 wasn't added in the other "lsp startup" module. Solution: Add it to the new module also.
This comment was marked as resolved.
This comment was marked as resolved.
justinmk3
commented
Apr 16, 2025
| '--pre-init-encryption', | ||
| '--set-credentials-encryption-key', | ||
| ] | ||
| const serverOptions = createServerOptions({ |
Contributor
Author
There was a problem hiding this comment.
I forgot that we have 2 of these modules. Will this module (packages/amazonq/src/lsp/client.ts) replace packages/core/src/amazonq/lsp/lspClient.ts @jpinkney-aws ?
Contributor
There was a problem hiding this comment.
lsp/client.ts is the amazon q language server, lsp/lspClient.ts is the workspace context language server
Contributor
There was a problem hiding this comment.
We may end up deprecating the lsp/lspClient.ts one eventually now that workspace context is technically in flare
Contributor
Author
There was a problem hiding this comment.
We may end up deprecating the
lsp/lspClient.tsone eventually now that workspace context is technically in flare
yes. also, this logic is pretty similar yet lives in 2 different places
jpinkney-aws
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The logic added in a264377 wasn't added in the other "lsp startup" module.
Solution:
Add it to the new module also.